RFR: JDK-8304959: Public API in javafx.css.Match should not return private API class PseudoClassState [v7]

Kevin Rushforth kcr at openjdk.org
Thu May 18 00:01:57 UTC 2023


On Wed, 17 May 2023 23:53:14 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

> Do you think this needs to be changed as part of this PR?

I'll answer this part of your question: No.

It seems out of scope for this particular bug fix, which is aimed at fixing an API and impl problem with `Match`, and should limit the changes to other classes to those needed to accomplish this.

It's great to point out existing weaknesses in, say, `BitSet`, but they should be addressed separately, after evaluating the need.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1070#discussion_r1197185891


More information about the openjfx-dev mailing list