RFR: 8306329 : Update ICU4C to 73.1 [v3]
Kevin Rushforth
kcr at openjdk.org
Thu May 18 13:00:57 UTC 2023
On Wed, 17 May 2023 11:47:11 GMT, Hima Bindu Meda <hmeda at openjdk.org> wrote:
>> Updated ICU to v73.1. Verified build and sanity. No issues seen.
>
> Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision:
>
> update license
This looks good with one comment about a missing LICENSE section.
modules/javafx.web/src/main/native/Source/ThirdParty/icu/LICENSE line 3:
> 1: COPYRIGHT AND PERMISSION NOTICE
> 2:
> 3: Copyright © 1991-2023 Unicode, Inc. All rights reserved.
This LICENSE file is missing the same preamble you recently added to `icu_web.md` lines 6-18. Or you can copy from:
https://github.com/unicode-org/icu/blob/release-73-1/icu4c/LICENSE
-------------
PR Review: https://git.openjdk.org/jfx/pull/1138#pullrequestreview-1432659228
PR Review Comment: https://git.openjdk.org/jfx/pull/1138#discussion_r1197782309
More information about the openjfx-dev
mailing list