RFR: JDK-8304959: Public API in javafx.css.Match should not return private API class PseudoClassState [v7]

Andy Goryachev angorya at openjdk.org
Thu May 18 19:50:02 UTC 2023


On Fri, 12 May 2023 23:40:03 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> The class `PseudoClassState` is private API, but was exposed erroneously in the CSS API. Instead, `Set<PseudoClass>` should have been used. This PR corrects this.
>
> John Hendrikx has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Override hashCode with a comment explaining why
>  - Fix style issues
>  - Restore removed public method

Consider this example:


    @Test
    public void testEquals() {
        PseudoClassState a = new PseudoClassState();
        StyleClassSet b = new StyleClassSet();
        assertFalse(a.equals(b));
    }

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1070#issuecomment-1553563061


More information about the openjfx-dev mailing list