RFR: JDK-8304959: Public API in javafx.css.Match should not return private API class PseudoClassState [v9]
Andy Goryachev
angorya at openjdk.org
Fri May 19 23:18:01 UTC 2023
On Fri, 19 May 2023 00:10:25 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:
>> The class `PseudoClassState` is private API, but was exposed erroneously in the CSS API. Instead, `Set<PseudoClass>` should have been used. This PR corrects this.
>
> John Hendrikx has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains three new commits since the last revision:
>
> - Add tests from #1076
> - Merge remote-tracking branch 'upstream/master' into feature/remove-private-api-in-css
> - Fix possible regression
tested with the MonkeyTester on macOS Ventura 13.3.1(a), including dynamic re-loading of the stylesheets. see no ill effects.
-------------
Marked as reviewed by angorya (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1070#pullrequestreview-1435260195
More information about the openjfx-dev
mailing list