RFR: 8273379: GTK3 stops sending key events during drag and drop [v32]

Thiago Milczarek Sayao tsayao at openjdk.org
Wed May 24 09:51:19 UTC 2023


On Mon, 8 May 2023 13:00:02 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:

>> Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 78 commits:
>> 
>>  - Merge branch 'master' into 8273379-dnd-keys
>>  - Merge branch 'master' into 8273379-dnd-keys
>>  - Merge branch 'master' into 8273379-dnd-keys
>>  - Merge branch 'openjdk:master' into master
>>  - Merge branch 'openjdk:master' into master
>>  - Merge branch 'openjdk:master' into master
>>  - Merge branch 'openjdk:master' into master
>>  - Merge branch 'openjdk:master' into master
>>  - Merge branch 'openjdk:master' into master
>>  - Merge branch 'openjdk:master' into master
>>  - ... and 68 more: https://git.openjdk.org/jfx/compare/c50ce609...53ee86e8
>
> apps/toys/DragDrop/src/dragdrop/DragDropDuke.java line 126:
> 
>> 124: 
>> 125:     private void subDownload() throws IOException {
>> 126:         URL url = new URL("http://cr.openjdk.java.net/~jeff/Duke/png/Hips.png");
> 
> I think, if possible, tests should be as independent from online-hosted content as possible (and in this case it seems like we only need an Image). I'd consider either adding Duke image to the repo, or (if adding a .png is not a good solution either - @kevinrushforth would have to confirm) generating a Test image.

There is already a similiar case on the same app (just for the sake of argumentation, but I will change if needed).

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/986#discussion_r1203814695


More information about the openjfx-dev mailing list