RFR: 8091153: Customize the Table Button Menu [v4]

Kevin Rushforth kcr at openjdk.org
Wed May 24 12:14:01 UTC 2023


On Wed, 17 May 2023 19:29:13 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> This PR implements a way to override the table column menu. 
>> When the `cornerRegion` is pressed, it will now call the `showColumnMenu` method. This new method is protected and therefore can be overidden by developers. If not overridden, the known default column 'ContextMenu' is created and shown.
>> 
>> This PR also resolves [JDK-8091419 ](https://bugs.openjdk.org/browse/JDK-8091419) (The method `showColumnMenu` can be overridden and made public now)
>> 
>> This PR also helps with [JDK-8092148](https://bugs.openjdk.org/browse/JDK-8092148), but does not address all the points mentioned in the ticket. 
>> Now that everyone can provide their own implementation, we can think of treating the current implementation of the table column menu as an [MVP](https://en.wikipedia.org/wiki/Minimum_viable_product) and any other requested feature/idea should be fulfilled by providing your own implementaion of the menu.
>
> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK-8091153: Added period to @implNote

The API and docs looks fine, as does the implementation and the tests.

Do you have an example application that overrides this new method? That would help ensure that this new API is sufficient to allow an app to create a custom menu. The main reason I ask is that the default implementation uses internal classes and methods that an application does not have access to. Knowing that an app can do what it needs using only public API will be useful. I expect that it is sufficient, but an example will verify this.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1135#pullrequestreview-1441683258


More information about the openjfx-dev mailing list