RFR: 8091153: Customize the Table Button Menu [v4]

Marius Hanl mhanl at openjdk.org
Wed May 24 16:55:16 UTC 2023


On Wed, 24 May 2023 13:23:46 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8091153: Added period to @implNote
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableHeaderRow.java line 472:
> 
>> 470:      *
>> 471:      * @implNote This method can be overridden to create and show a custom menu.
>> 472:      * @param mouseEvent the {@link MouseEvent} which was generated when the table menu button was pressed
> 
> There's no need to link to method parameters (`MouseEvent`) since they already linked in the method description.

okay. Replaced with `@code`.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1135#discussion_r1204498489


More information about the openjfx-dev mailing list