RFR: 8091153: Customize the Table Button Menu [v5]

Kevin Rushforth kcr at openjdk.org
Thu May 25 16:52:03 UTC 2023


On Wed, 24 May 2023 16:55:11 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> This PR implements a way to override the table column menu. 
>> When the `cornerRegion` is pressed, it will now call the `showColumnMenu` method. This new method is protected and therefore can be overidden by developers. If not overridden, the known default column 'ContextMenu' is created and shown.
>> 
>> This PR also resolves [JDK-8091419 ](https://bugs.openjdk.org/browse/JDK-8091419) (The method `showColumnMenu` can be overridden and made public now)
>> 
>> This PR also helps with [JDK-8092148](https://bugs.openjdk.org/browse/JDK-8092148), but does not address all the points mentioned in the ticket. 
>> Now that everyone can provide their own implementation, we can think of treating the current implementation of the table column menu as an [MVP](https://en.wikipedia.org/wiki/Minimum_viable_product) and any other requested feature/idea should be fulfilled by providing your own implementaion of the menu.
>
> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK-8091153: Replace @link with @code

This looks good. If you haven't already done so, can you change `@link` to `@code` in the CSR to match? I'll review that next.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1135#pullrequestreview-1444305363


More information about the openjfx-dev mailing list