RFR: 8301312: Create implementation of NSAccessibilityButton protocol [v5]
Alexander Zuev
kizune at openjdk.org
Thu May 25 20:22:07 UTC 2023
> Add the common base component for all the new implementing native classes Change native peer creation to use the new base component The new code will instantiate new protocol implementation for the given role if it exists or an old one if it does not exist
> Added BUTTON role implementing class
Alexander Zuev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
- Merge remote-tracking branch 'refs/remotes/origin/JDK-8301312' into JDK-8301312
- Properly use NSObject instead of the GlassAccessible type.
- Fixed situation when performAction throws an exception on Java side - now we are properly
returning FALSE notifying system that action has not been performed successfully.
- Fixes based on review.
Modified parent retrieval to cache the parent inside the component peer because retrieving parent every time
can be costly.
- 8301312: Create implementation of NSAccessibilityButton protocol
Add the common base component for all the new implementing native classes
Change native peer creation to use the new base component
The new code will instantiate new protocol implementation for the given role
if it exists or an old one if it does not exist
Added BUTTON role implementing class
- Properly use NSObject instead of the GlassAccessible type.
- Fixed situation when performAction throws an exception on Java side - now we are properly
returning FALSE notifying system that action has not been performed successfully.
- Fixes based on review.
Modified parent retrieval to cache the parent inside the component peer because retrieving parent every time
can be costly.
- 8301312: Create implementation of NSAccessibilityButton protocol
Add the common base component for all the new implementing native classes
Change native peer creation to use the new base component
The new code will instantiate new protocol implementation for the given role
if it exists or an old one if it does not exist
Added BUTTON role implementing class
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/1084/files
- new: https://git.openjdk.org/jfx/pull/1084/files/d7602336..29cb4b2c
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=1084&range=04
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=1084&range=03-04
Stats: 15589 lines in 219 files changed: 12539 ins; 2237 del; 813 mod
Patch: https://git.openjdk.org/jfx/pull/1084.diff
Fetch: git fetch https://git.openjdk.org/jfx.git pull/1084/head:pull/1084
PR: https://git.openjdk.org/jfx/pull/1084
More information about the openjfx-dev
mailing list