RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621 [v6]

Thiago Milczarek Sayao tsayao at openjdk.org
Sat May 27 13:39:09 UTC 2023


On Mon, 1 May 2023 12:33:10 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:

>> Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 46 additional commits since the last revision:
>> 
>>  - Review changes
>>  - Merge branch 'master' into change_scene_fix
>>  - Change call to requestFocus
>>  - Revert "The window could start iconified."
>>    
>>    This reverts commit f92e25cbcc24fd772b9d6bb25a92386ec0561313.
>>  - The window could start iconified.
>>  - Request Focus on setVisible
>>  - fix mistake
>>  - Scene not rendered initially when changing scenes after fix for JDK-8296621
>>  - Merge branch 'openjdk:master' into master
>>  - Merge branch 'openjdk:master' into master
>>  - ... and 36 more: https://git.openjdk.org/jfx/compare/d3f03864...2649d15c
>
> I verified the changes, in general the `testSecondSetScene` test is now passing on all platforms. However, on Windows and macOS I observed two tests from controls test suite failing:
> * MouseEventFirerTest. testAnchorRight[0]
> * ComboBoxTest. test_rt28245
> 
> When I change branches to before all these changes - 48b5fea374 - or even before the most recent master that's merged to these tests - 559ad1139b - these tests pass. Seems like these two failures were introduced by this PR.

@lukostyra those tests that were failing are passing now.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1110#issuecomment-1565423094


More information about the openjfx-dev mailing list