Withdrawn: 8299423: JavaFX Mac system menubar leaks

duke duke at openjdk.org
Mon May 29 10:09:08 UTC 2023


On Fri, 30 Dec 2022 09:41:46 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:

> This PR fixes the leak in the mac system menu bar.
> 
> Inside the native code, NewGlobalRef is called for the callable.
> Which makes it into a "GC-Root" until DeleteGlobalRef is called.
> 
> The DeleteGlobalRef is never called for the MenuEntry, if it's removed from the menu without removing it's callable.
> This PR adds logic, whether the Menu is inserted. If it's not inserted in a Menu anymore, then DeleteGlobalRef is called, by calling `_setCallback` with the callable "null".
> 
> The unit test verifies, that this bug happened without this change, but no longer happens with this change.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jfx/pull/987


More information about the openjfx-dev mailing list