RFR: 8308308: Update to Visual Studio 2022 version 17.5.0 on Windows

[Kevin Rushforth]

On Fri, 26 May 2023 11:13:31 GMT, Joeri Sykora <sykora at openjdk.org> wrote:

>> Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides the needed C++20 support for the next WebKit update.
>> 
>> On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022 17.5.0 -- see [JDK-8303748](https://bugs.openjdk.org/browse/JDK-8303748). The solution for the failure is to compile 615.1 using the C++20 flag for Windows (we will use this flag on all platforms for the next WebKit update). The fix for that bug is necessarily included in this PR, since the two fixes as interdependent.
>
> I still get the same error when building with Windows SDK version `10.0.22621` (was using `10.0.22000` before). This is our output of the lines you pasted:
> 
> 
> -- The C compiler identification is MSVC 19.35.32215.0
> -- The CXX compiler identification is MSVC 19.35.32215.0
> -- Check for working C compiler: C:/PROGRA~2/MICROS~1/2022/17.5.0/VC/Tools/MSVC/14.35.32215/bin/Hostx64/x64/cl.exe
> -- Check for working C compiler: C:/PROGRA~2/MICROS~1/2022/17.5.0/VC/Tools/MSVC/14.35.32215/bin/Hostx64/x64/cl.exe -- works
> -- Detecting C compiler ABI info
> -- Detecting C compiler ABI info - done
> -- Detecting C compile features
> -- Detecting C compile features - done
> -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2022/17.5.0/VC/Tools/MSVC/14.35.32215/bin/Hostx64/x64/cl.exe
> -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2022/17.5.0/VC/Tools/MSVC/14.35.32215/bin/Hostx64/x64/cl.exe -- works
> -- Detecting CXX compiler ABI info
> -- Detecting CXX compiler ABI info - done
> -- Detecting CXX compile features
> -- Detecting CXX compile features - done
> -- The CMake build type is: Release
> -- Found Perl: C:/cygwin64/bin/perl.exe (found suitable version "5.32.1", minimum required is "5.10.0") 
> -- Found PerlModules: TRUE  found components:  English FindBin JSON::PP 
> -- Found Python: C:/cygwin64/bin/python3.8.exe (found version "3.8.10") found components:  Interpreter 
> -- Could NOT find Ruby (missing: RUBY_INCLUDE_DIR RUBY_LIBRARY RUBY_CONFIG_INCLUDE_DIR) (found suitable version "2.6.4", minimum required is "1.9")
> -- Enabling ccache: Couldn't find ccache program. Not enabling it.
> 
> 
> For reference, I'll paste the full error message below:
> 
> 
> FAILED: Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-66f79d8a-1.cpp.obj 
> C:\PROGRA~2\MICROS~1\2022\175~1.0\VC\Tools\MSVC\1435~1.322\bin\Hostx64\x64\cl.exe  /nologo /TP -DBUILDING_JAVA__=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_WebCore -DDATA_DIR="share" -DHAVE_CONFIG_H=1 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -DIMAGEIO=1 -DLIBXML_STATIC -DLIBXSLT_STATIC -DMAX_DOM_TREE_DEPTH=2000 -DNOMINMAX -DPAS_BMALLOC=1 -DSTATICALLY_LINKED_WITH_JavaScriptCore -DSTATICALLY_LINKED_WITH_PAL -DSTATICALLY_LINKED_WITH_WTF -DUNICODE -DUSE_SYSTEM_MALLOC -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DWINVER=0x601 -D_CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES=1 -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_UNICODE -D_WINDOWS -D_WINSOCKAPI_=""...

> @tiainen Could you please try with python3.8.8 and share your observations?

I would be very surprised if a micro version difference in python caused any problems, but if it's easy, it might be worth trying.

One other possibility occurred to me. Are you using the Community edition of Visual Studio? Our devkit is based on (I think) the Professional edition (it might be the Enterprise edition...I'm checking into that).

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1142#issuecomment-1568649491