RFR: 8299756: Minor updates in CSS Reference [v2]

Andy Goryachev angorya at openjdk.org
Tue May 30 15:50:18 UTC 2023


On Sat, 27 May 2023 13:19:02 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line 367:
> 
>> 365:         </ul>
>> 366:       </li>
>> 367:       <li><a id="controls">Controls</a>
> 
> We should consider leaving this as `href` and adding a `Controls` heading instead.
> It should be here: 
> ![image](https://github.com/openjdk/jfx/assets/66004280/be1134e5-91df-4650-b56d-3f6ecd7cc18a)
> As it is for all other headers e.g. `Nodes`
> ![image](https://github.com/openjdk/jfx/assets/66004280/17eba5ee-9804-4452-aaf2-b8448a9d4cb4)

you are right

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1144#discussion_r1210476593


More information about the openjfx-dev mailing list