RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v13]

John Hendrikx jhendrikx at openjdk.org
Wed Nov 1 14:57:16 UTC 2023


On Tue, 31 Oct 2023 21:55:20 GMT, Sai Pradeep Dandem <duke at openjdk.org> wrote:

>> **Issue:**
>> Using pseudo classes in programmatic query using Node.lookupAll() or Node.lookup() gives unexpected results.
>> 
>> **Cause:**
>> There is no check for checking the psuedo states matching in the applies() method of SimpleSelector.java. So checking for "applies()" alone is not sufficient in lookup() method.
>> 
>> **Fix:**
>> Included an extra check for the psuedo states to match.
>
> Sai Pradeep Dandem has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8185831: Changes to doc as per review comments

Looks good, no comments

-------------

Marked as reviewed by jhendrikx (Committer).

PR Review: https://git.openjdk.org/jfx/pull/1245#pullrequestreview-1708395985


More information about the openjfx-dev mailing list