RFR: 8301302: Platform preferences API [v19]

Michael Strauß mstrauss at openjdk.org
Wed Nov 1 17:28:42 UTC 2023


On Wed, 1 Nov 2023 15:18:01 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/com/sun/javafx/application/preferences/PlatformPreferences.java line 122:
>> 
>>> 120: 
>>> 121:     @Override
>>> 122:     public Optional<Integer> getInteger(String key) {
>> 
>> Q: is it possible to encounter an unsigned 64 bit value? 
>> Should we allow for BigInteger?
>
> IMHO this can be added when there's a use case.
> 
> Also, an int can support all values of an unsigned variant, you just need to be careful when interpreting it (ie. do `long unsigned = i & 0xffffffffL` first).

I also think that that's an addition for another day.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1379098296


More information about the openjfx-dev mailing list