[jfx-tests] Integrated: 8315896: Perspective lod tests fail because of minute difference in values

[Jayathirth D V]

On Fri, 8 Sep 2023 07:07:40 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

> Two perspective lod tests fail because of minute differences in expected values.
> 
> Failing tests:
> test/scenegraph/fx3d/lod/PerspectiveLodCameraTest.java:
> test/scenegraph/fx3d/lod/PerspectiveLodGroupTest.java: 
> 
> Exception:
> test test.scenegraph.fx3d.lod.LodTests.sphereInitialLightOnTest(): failure
> org.jemmy.TimeoutExpiredException: State 'Expected 50180.140882730484, but was 50180.137157440186' has not been reached in 1000 milliseconds
> at org.jemmy.timing.Waiter.ensureValue(Waiter.java:93)
> at test.scenegraph.fx3d.lod.LodTestBase.checkLod(LodTestBase.java:117)
> at test.scenegraph.fx3d.lod.LodTests.sphereInitialLightOnTest(LodTests.java:98)
> at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
> at java.base/java.lang.reflect.Method.invoke(Method.java:577)
> at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
> at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at java.base/java.lang.Thread.run(Thread.java:833) 
> 
> These little difference in values are seen both initial drawing and updates.
> These tests are not run from long time and change in product might change lod values.
> 
> With updated lod values i have verified that both the tests pass in OpenGL and Metal pipeline with both retina display(scale = 2) and external monitor(scale = 1).

This pull request has now been integrated.

Changeset: e5f951c7
Author:    Jayathirth D V <jdv at openjdk.org>
Committer: Kevin Rushforth <kcr at openjdk.org>
URL:       https://git.openjdk.org/jfx-tests/commit/e5f951c77a315c224710e47cba0ef8084e3a7d8d
Stats:     10 lines in 3 files changed: 1 ins; 0 del; 9 mod

8315896: Perspective lod tests fail because of minute difference in values

Reviewed-by: kcr

-------------

PR: https://git.openjdk.org/jfx-tests/pull/6