RFR: 8319147: Add regression test for JDK-8317836

[Kevin Rushforth]

On Thu, 2 Nov 2023 06:04:23 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> A manual regression test for JFXPanel orientation fix in [JDK-8317836](https://bugs.openjdk.org/browse/JDK-8317836) is added

I verified that this test passes with the fix for JDK-8317836 and fails with that fix locally reverted.

The only minor thing I noticed is that the instruction window is obscured by the test window, so you have to move the test window out of the way to see it. Maybe set the X and Y of the instruction window and/or make the test window smaller so they don't overlap?

If you would like to fix this, I also left two very minor code format comments that you might consider. I'll approve anyway, and reapprove if you make the changes.

tests/manual/swing/JFXPanelOrientationTest.java line 25:

> 23:  * questions.
> 24:  */
> 25: import java.awt.BorderLayout;

Minor: we prefer a blank line between the copyright block and the package or import statements.

tests/manual/swing/JFXPanelOrientationTest.java line 46:

> 44: import javafx.scene.layout.VBox;
> 45: 
> 46: 

Minor: you can remove the extra blank line.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1276#pullrequestreview-1713775541
PR Review Comment: https://git.openjdk.org/jfx/pull/1276#discussion_r1382396717
PR Review Comment: https://git.openjdk.org/jfx/pull/1276#discussion_r1382396762