RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu [v3]

Kevin Rushforth kcr at openjdk.org
Wed Nov 8 16:09:13 UTC 2023


On Wed, 8 Nov 2023 15:19:58 GMT, vlaaad <duke at openjdk.org> wrote:

>> vlaaad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Don't use NSFunctionKeyMask as modifier at all
>
> Yay! Is there any ETA for a new javafx version with this changeset?

> @vlaaad The SKARA bot hasn't marked this as ready.

This is because Skara doesn't know that @beldenfox is the same as OpenJDK user `mfox`. To allow Skara to recognize you, follow the instruction on the Skara Wiki to [associate your GitHub account and OpenJDK username](https://wiki.openjdk.org/display/SKARA#Skara-AssociatingyourGitHubaccountandyourOpenJDKusername).

> I suspect you need to turn on pre-submit tests in your repo. See the Details link next to the line where it says pre-submit tests were skipped.

This is a good idea in any case. Skara doesn't care, but it is helpful for reviewers.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1252#issuecomment-1802200446


More information about the openjfx-dev mailing list