RFR: 8319669: [macos14] Running any JavaFX app prints Secure coding warning [v2]

Kevin Rushforth kcr at openjdk.org
Wed Nov 8 19:49:09 UTC 2023


On Wed, 8 Nov 2023 18:52:23 GMT, Phil Race <prr at openjdk.org> wrote:

>> Kevin Rushforth has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typo: remove redundant `isEmbedded =` assignement
>
> modules/javafx.graphics/src/main/native-glass/mac/GlassApplication.m line 543:
> 
>> 541:         // Determine if we're running embedded (in AWT, SWT, elsewhere)
>> 542:         NSApplication *app = [NSApplicationFX sharedApplication];
>> 543:         isEmbedded = isEmbedded = ![app isKindOfClass:[NSApplicationFX class]];
> 
> why is there a double assignment here ?

That was a typo. Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1280#discussion_r1387125250


More information about the openjfx-dev mailing list