RFR: 8318841: macOS: Memory leak with MenuItem when Menu.useSystemMenuBar(true) is used [v4]

[Johan Vos]

On Wed, 8 Nov 2023 18:56:54 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Johan Vos has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add a system test
>
> tests/system/src/test/java/test/javafx/stage/SystemMenuBarTest.java line 165:
> 
>> 163:                     uncollectedMenuItems.removeIf(ref -> ref.get() == null);
>> 164:                     assertEquals(1, uncollectedMenuItems.size(), "Only the last menuItem should be alive");
>> 165:                     memoryLatch.countDown();
> 
> If there is a failure, this statement will be unreached. This is why I recommended also doing a countDown on this latch in the `UncaughtExceptionHandler`

Done

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1277#discussion_r1387953005