Integrated: 8274967: KeyCharacterCombinations for punctuation and symbols fail on non-US keyboards

Martin Fox mfox at openjdk.org
Wed Nov 15 00:02:42 UTC 2023


On Tue, 17 Oct 2023 20:21:30 GMT, Martin Fox <mfox at openjdk.org> wrote:

> After finding the Window virtual key code for a character getKeyCodeForChar was using a mapping table that only works correctly for U.S. English to retrieve the Java key code. This caused getKeyCodeForChar to encode keys differently than the original key event handling machinery.
> 
> With this fix the Robot, getKeyCodeForChar, and the code that handles platform key events all agree on how Windows VK codes should map to Java codes.
> 
> The manual KeyboardTest app can be used to test this (tests/manual/events). Run the tests by selecting "without keypad combinations" in the second dropdown. This will use a Robot to test KeyCharacterCombinations excluding the numeric keypad (which is a separate issue).

This pull request has now been integrated.

Changeset: c8b44bec
Author:    Martin Fox <mfox at openjdk.org>
Committer: Andy Goryachev <angorya at openjdk.org>
URL:       https://git.openjdk.org/jfx/commit/c8b44bec14396d2fb4c8a51a56db957b8fdd361f
Stats:     18 lines in 1 file changed: 16 ins; 0 del; 2 mod

8274967: KeyCharacterCombinations for punctuation and symbols fail on non-US keyboards

Reviewed-by: angorya, jpereda

-------------

PR: https://git.openjdk.org/jfx/pull/1264


More information about the openjfx-dev mailing list