RFR: 8303478: DatePicker throws uncatchable exception on tab out from garbled text [v3]

brunesto duke at openjdk.org
Wed Nov 15 09:38:47 UTC 2023


On Tue, 14 Nov 2023 21:31:59 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> brunesto has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor
>
> modules/javafx.controls/src/main/java/javafx/scene/control/DatePicker.java line 151:
> 
>> 149:         focusedProperty().addListener(o -> {
>> 150:             if (!isFocused()) {
>> 151:                 commitValueOnFocusLost();
> 
> minor: I don't know if it's worth creating a new method here - try .. catch can simply be moved here.

I have removed the `commitValueOnFocusLost()` method.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1274#discussion_r1393920300


More information about the openjfx-dev mailing list