RFR: 8092272: [D3D 3D] Need a robust 3D states management for texture [v2]

Nir Lisker nlisker at openjdk.org
Wed Nov 15 13:03:46 UTC 2023


On Mon, 13 Nov 2023 01:23:13 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> About 2, I tried that initially and got into problems iterating over the enum in `D3DMeshView.cc` line 293. How would you perform the iteration?
>
> You're right, there's no implicit conversion from scoped enums to integers. While one could get very creative with C++, maybe just using an unscoped enum is easier. You might want to prefix the constants with `MT_` or something like that.

The constants are referred as `MapType::BUMP` etc. I don't see what adding a prefix will achieve.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1281#discussion_r1394169100


More information about the openjfx-dev mailing list