[External] : Re: ImageView.fitWidth()/.fitHeight()/.preserveRatio() styling

[Andy Goryachev]

Created https://bugs.openjdk.org/browse/JDK-8320359

-andy

From: Dirk Lemmermann <dlemmermann at gmail.com>
Date: Friday, November 17, 2023 at 14:48
To: Andy Goryachev <andy.goryachev at oracle.com>
Cc: openjfx-dev <openjfx-dev at openjdk.org>
Subject: [External] : Re: ImageView.fitWidth()/.fitHeight()/.preserveRatio() styling
I guess the use-case is the same as for any node property. I want to be able to specify it via CSS instead of code.

I could easily implement this for ImageView but I am not familiar with the OpenJFX dev process (e.g. which tests are required), so it would take me a long time to do. Pretty sure that other contributors could do this in a fraction of the time.

Dirk


Am 16.11.2023 um 20:57 schrieb Andy Goryachev <andy.goryachev at oracle.com>:

Dear Dirk:

I don’t see any reason why not - we’d need to add entries in getCssMetaData() and update CSS reference.  In fact, there is a TODO item in ImageView:812 along the lines

        // TODO
        // "preserve-ratio","smooth","viewport","fit-width","fit-height"

Perhaps it just fell through the cracks.

Can you describe your use case?  Is this something you’d like to impement?

-andy

From: openjfx-dev <openjfx-dev-retn at openjdk.org> on behalf of Dirk Lemmermann <dlemmermann at gmail.com>
Date: Thursday, November 16, 2023 at 07:12
To: openjfx-dev <openjfx-dev at openjdk.org>
Subject: ImageView.fitWidth()/.fitHeight()/.preserveRatio() styling
Hi everyone,

Is there a particular reason why the fitWidth, fitHeight, and preserveRatio() properties of an ImageView can not be styled via CSS?

Dirk

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/openjfx-dev/attachments/20231117/f0849a21/attachment.htm>