RFR: 8301302: Platform preferences API [v23]

[Michael Strauß]

On Fri, 17 Nov 2023 19:03:16 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename Appearance to ColorScheme
>
> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line 469:
> 
>> 467:      * the untyped {@link #get} method.
>> 468:      * <p>
>> 469:      * The preferences that are reported by the platform may be dependent on the operating system version,
> 
> They also might be dependent on some mode of operation of the platform. Do you think that's worth calling out?

Yes, I've included `and its current configuration` after `operating system version`.

> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line 632:
> 
>> 630:          * @return the optional {@code Integer} to which the key is mapped
>> 631:          */
>> 632:         Optional<Integer> getInteger(String key);
> 
> Did you consider using `OptionalInt` instead of `Optional<Integer>`? What you chose seems more consistent (e.g., there is no `OptionalBoolean` class, so `getBoolean` has to return an `Optional<Boolean>`), so I wouldn't advocate changing it.

I did consider it, but decided not to do it for consistency.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1398101875
PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1398101579