RFR: 8301302: Platform preferences API [v26]

Nir Lisker nlisker at openjdk.org
Sat Nov 18 17:11:11 UTC 2023


On Sat, 18 Nov 2023 05:50:35 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> Please read [this document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for an introduction to the Platform Preferences API, and how it interacts with the proposed style theme and stage appearance features.
>
> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove Preferences.getPaint

modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/GtkApplication.java line 486:

> 484:     @Override
> 485:     public Map<String, Class<?>> getPlatformKeys() {
> 486:         return new HashMap<>() {{

Any reason this map and the like are not `Map.ofEntries`? The double braces syntax is not a good idea in general as it creates a subclass of `HashMap` for just one initialization.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1398240860


More information about the openjfx-dev mailing list