RFR: 8320796: CssMetaData.combine() [v4]

[Michael Strauß]

On Tue, 28 Nov 2023 00:51:36 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Provides a public utility method for use by the skins (core and custom) to simplify initialization of styleable properties.
>> 
>> 
>> + /**
>> + * Utility method which combines CssMetaData items in one unmodifiable list with the size equal to the number
>> + * of items it holds (i.e. with no unnecessary overhead).
>> + *
>> + * @param list the css metadata items, usually from the parent, not nullable
>> + * @param items the additional items
>> + * @return the unmodifiable list containing all of the items
>> + *
>> + * @since 22
>> + */
>> + public static List<CssMetaData<? extends Styleable, ?>> combine(
>> + List<CssMetaData<? extends Styleable, ?>> list,
>> + CssMetaData<? extends Styleable, ?>... items)
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   combine

modules/javafx.graphics/src/main/java/javafx/css/CssMetaData.java line 333:

> 331:     /**
> 332:      * Utility method which combines {@code CssMetaData} items in one unmodifiable list with size equal
> 333:      * to the number of items it holds.

It is trivially true that the size of a list is equal to the number of its items, maybe you wanted to say "capacity"?

In any case, I don't think that this is relevant information (the list is unmodifiable, so its capacity is of no concern or use to the caller). However, I think you could say a word or two about why this method is here in the first place, namely to support implementing `getClassCssMetaData()`. Maybe even give a code sample of how to do it properly.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1296#discussion_r1408188313