RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v10]

[Thiago Milczarek Sayao]

On Tue, 28 Nov 2023 20:38:25 GMT, Martin Fox <mfox at openjdk.org> wrote:

>> Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make it a default method for compatibility
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/GtkView.java line 105:
> 
>> 103:     @Override
>> 104:     protected void _finishInputMethodComposition(long ptr) {
>> 105:         //nothing
> 
> See [JDK-8320912](https://bugs.openjdk.org/browse/JDK-8320912). This routine is called when the focus moves from one TextInputControl to another. Doing nothing here leaves the previous field in a bad state.

You're right. Fixed it.

> modules/javafx.graphics/src/main/native-glass/gtk/GlassApplication.cpp line 450:
> 
>> 448:     }
>> 449: 
>> 450:     if (event->type == GDK_KEY_PRESS && ctx != NULL && ctx->filterIME(event)) {
> 
> In the previous code both PRESS and RELEASE events were sent to the filter and gtk_im_context_filter_keypress says that it can filter both. Is there some particular reason you're not calling this on RELEASE events?

It seems to have no effect on RELEASE, but as the documentation states [press and realease](https://docs.gtk.org/gtk3/method.IMContext.filter_keypress.html) I've restored it.

> modules/javafx.graphics/src/main/native-glass/gtk/glass_window.h line 34:
> 
>> 32: #include <set>
>> 33: #include <vector>
>> 34: #include <queue>
> 
> Doesn't look like you're using this.

Removed

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1080#discussion_r1408450288
PR Review Comment: https://git.openjdk.org/jfx/pull/1080#discussion_r1408449751
PR Review Comment: https://git.openjdk.org/jfx/pull/1080#discussion_r1408449922