RFR: 8316518 javafx.print.Paper getWidth / getHeight rounds values, causing errors.
Kevin Rushforth
kcr at openjdk.org
Tue Nov 28 22:20:23 UTC 2023
On Tue, 17 Oct 2023 09:23:16 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:
>> The Method javafx.print.getWidth and getHeight returns a double of points.
>> But the values are always rounded to full integers. This causes especially problems,
>> with mm based Papers.
>>
>> I asked in the mailing list, with the conclusion (me and John Hendrix) that is best to just fix this behavior by removing the rounding.
>
> It would be nice if something could be decided here.
>
> Another option would be, to rename the current method to something like getWidthInPoints() which then can be used internally. But the old - now correct methods - can be exposed to applications, returning correct values.
>
> But I would still prefer to just fix it, returning the correct values. And if it turns out, at some part we need it in points, then we just have to convert it to this location. I still don't see how the current state doesn't lead to various incorrect behaviors.
@FlorianKirmaier This PR is ready for you to `/integrate`
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1244#issuecomment-1830847681
More information about the openjfx-dev
mailing list