RFR: 8320773: [macOS] All IME input blocked

Tue Nov 28 23:23:17 UTC 2023

On Mon, 27 Nov 2023 17:07:38 GMT, Martin Fox <mfox at openjdk.org> wrote:

> The changes submitted in PR #1209 broke IME input on macOS 12 and 13 (at least on Apple Silicon). Calling charactersByApplyingModifiers on an NSEvent alters its state in some way that confuses NSTextInputContext.handleEvent. The result is that all key events are discarded if an IME is active. Apple fixed this bug in macOS 14 Sonoma.
> 
> In this PR we switch to using the same Carbon call that we started using in PR #425 (jfx21) to query the keyboard layout.
> 
> This is a new implementation of the fix for [JDK-8087700](https://bugs.openjdk.org/browse/JDK-8087700) so that bug will need to be re-tested.

Looks good. I verified that it fixes the problem.

@beldenfox I recommend waiting for a day to integrate this in case @jperedadnr has any comments.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1295#pullrequestreview-1754119136