Integrated: 8320773: [macOS] All IME input blocked

Wed Nov 29 15:34:27 UTC 2023

On Mon, 27 Nov 2023 17:07:38 GMT, Martin Fox <mfox at openjdk.org> wrote:

> The changes submitted in PR #1209 broke IME input on macOS 12 and 13 (at least on Apple Silicon). Calling charactersByApplyingModifiers on an NSEvent alters its state in some way that confuses NSTextInputContext.handleEvent. The result is that all key events are discarded if an IME is active. Apple fixed this bug in macOS 14 Sonoma.
> 
> In this PR we switch to using the same Carbon call that we started using in PR #425 (jfx21) to query the keyboard layout.
> 
> This is a new implementation of the fix for [JDK-8087700](https://bugs.openjdk.org/browse/JDK-8087700) so that bug will need to be re-tested.

This pull request has now been integrated.

Changeset: c46c172b
Author:    Martin Fox <mfox at openjdk.org>
Committer: Andy Goryachev <angorya at openjdk.org>
URL:       https://git.openjdk.org/jfx/commit/c46c172be65370ef1a121d80b71cfb34cf887d2e
Stats:     32 lines in 4 files changed: 29 ins; 1 del; 2 mod

8320773: [macOS] All IME input blocked

Reviewed-by: angorya, kcr, jpereda

-------------

PR: https://git.openjdk.org/jfx/pull/1295