RFR: 8320796: CssMetaData.combine() [v6]

Wed Nov 29 16:12:23 UTC 2023

On Wed, 29 Nov 2023 15:57:46 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> > when Skin changes happen
> 
> can you please explain how Skins have managed to enter the discussion? Styleable properties are a part of the Control, they have nothing to do with Skins.

Skins seem to be everywhere. In particular, skins can extend the list of styleable properties: `Control` overrides `getCssMetaData()` with a `final` modifier, and then combines metadata from two sources: a new `Control.getControlCssMetaData()` method, and `SkinBase.getCssMetaData()`. This introduces yet another moving part, namely that the list of styleable properties can change when the control skin is changed.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1296#issuecomment-1832211934