RFR: 8301302: Platform preferences API [v32]

Kevin Rushforth kcr at openjdk.org
Wed Nov 29 22:06:57 UTC 2023


On Fri, 24 Nov 2023 19:26:05 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> Please read [this document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for an introduction to the Platform Preferences API, and how it interacts with the proposed style theme and stage appearance features.
>
> Michael Strauß has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - typo
>  - rename local variables

I did a quick test instrumenting the destructor with print statements, and I'm pretty sure I know why it's crashing. You don't initialize `preferences` in the constructor, so the null check in the destructor is reading uninitialized data in case the preferences are never created. if you add `, preferences(NULL)` that should fix it.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1014#issuecomment-1832773571


More information about the openjfx-dev mailing list