RFR: 8320796: CssMetaData.combine() [v6]

[John Hendrikx]

On Wed, 29 Nov 2023 22:28:56 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

> > There are definitely some (preexisting) oddities of how CSS styleable properties are managed. And it's good to examine them in the context of this newly proposed utility method. Having said that, it still seems to me that this new utility method is useful in providing a better pattern for Node subclasses to create the immutable list of stylables. As an example, see the following from Andy's draft PR to initialize the `STYLEABLES` in Image:
> > ```java
> >     private static final List<CssMetaData<? extends Styleable, ?>> STYLEABLES = CssMetaData.combine(
> >         Node.getClassCssMetaData(),
> >         FIT_HEIGHT,
> >         FIT_WIDTH,
> >         IMAGE,
> >         PRESERVE_RATIO,
> >         SMOOTH
> >     );
> > ```
Would this not still require a `static` `getClassCssMetaData` method so subclasses have a way of getting these? `ImageView` is not final, and I didn't see that method.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1296#issuecomment-1832837761