RFR: 8320359: ImageView: add styleable fitWidth, fitHeight, preserveRatio, smooth properties

Andy Goryachev angorya at openjdk.org
Thu Nov 30 16:58:21 UTC 2023


On Thu, 30 Nov 2023 16:50:53 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> Adding missing styleable properties to ImageView:
>> 
>> 
>> -fx-preserve-ratio
>> -fx-smooth
>> -fx-fit-width
>> -fx-fit-height
>> 
>> 
>> Updated CSS Reference.
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/css/CssUtil.java line 36:
> 
>> 34:  * Utility methods for dealing with CSS.
>> 35:  */
>> 36: public class CssUtil {
> 
> I think it's best for utility classes to make it `final` and the constructor `private`.

this class is not accessible to the outside world, but sure, will do.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1293#discussion_r1410966388


More information about the openjfx-dev mailing list