[jfx-tests] RFR: 8315896: Perspective lod tests fail because of minute difference in values
Jayathirth D V
jdv at openjdk.org
Tue Oct 3 07:09:13 UTC 2023
On Fri, 8 Sep 2023 13:13:56 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
> Two questions:
>
> 1. Have you run this on Windows to ensure that the D3D pipeline also passes with this change?
>
> 2. It might be better to compare using a tolerance rather than relying on an exact value being computed in floating-point arithmetic.
Thanks @kevinrushforth for your inputs.
I have added tolerance which is definitely better than using fixed value for lod.
I have tried running jfx-tests using cygwin as well as cmd in windows.
For cygwin i followed same approach as we follow for macOS but with different path separator. Also https://ant.apache.org/manual/running.html talks about not using cygwin path for ant -Dproperty and i used absolute path. With all these still ant is not able to find javafx.home and jemmy-v3.jars. But with same path pattern it is able to find jtreg.home.
For cmd, i added needed environment variables but there also i am not able to run the tests.
I think its better to handle making jfx-tests run in Windows as part of separate bug.
Current change without verification in D3D will help in atleast comparing functionality between OpenGL and Metal in macOS.
-------------
PR Comment: https://git.openjdk.org/jfx-tests/pull/6#issuecomment-1744315190
More information about the openjfx-dev
mailing list