RFR: JDK-8317308 JavaFX Developer build broken on Windows - NativeLibrary file contains invalid character ':'

[John Neffenger]

On Fri, 29 Sep 2023 10:40:52 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:

> The format of the timestamp has changed to ISO 8601. This contains the “:” Character.
> A copy of the dll is saved at <home>/.openjfx/cache/" + jfxVersion + "/" + arch .
> On Windows, the character ‘:’ is invalid in files, causing internal errors.
> 
> This only happens on developer/non-hudson builds, because on hudson-builds, the timestamp is omitted.
> 
> I just replaced the disallowed character when creating the native library.

The follow-up pull request is [8317370: JavaFX runtime version is wrong at runtime][1]. I'll mark it ready for review when I finish running all of my test cases.

> On my fork, the code to add the "-internal" for non-hudson builds is removed.

@FlorianKirmaier You can remove "-internal" from the version string by overriding the `RELEASE_SUFFIX` property on the command line instead of modifying the build file. For example:


# Sets the environment variable for reproducible builds
SOURCE_DATE_EPOCH=$(git log -1 --pretty=%ct)
export SOURCE_DATE_EPOCH

# Builds JavaFX
bash gradlew --no-daemon \
    -PPROMOTED_BUILD_NUMBER="31" \
    -PRELEASE_SUFFIX="" \
    -PJDK_DOCS="$JDK_DOCS" \
    sdk jmods javadoc


[1]:https://github.com/openjdk/jfx/pull/1253

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1251#issuecomment-1745229148