RFR: 8296266: TextArea: Navigation breaks with RTL text
Ajit Ghaisas
aghaisas at openjdk.org
Wed Oct 4 09:43:47 UTC 2023
On Tue, 22 Aug 2023 20:46:21 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
> The fix uses character BreakIterator instead of the logic that relies on caretBounds/hitTest/rangeShape in TextInputControl.nextCharacterVisually().
>
> I believe this is a more reliable method of navigation, as it behaves in sync with the jdk break iterator, thought it might work differently around grapheme clusters, considering a recent change JDK-8291660
>
> This change also introduces TextInputControlHelper class (impl. detail) which gives access to character- and word- break iterators cached by TextInputControl (*some say* these iterators and associated editing logic should be a part of Content implementation, but that's a discussion for another day).
The fix seems logical.
-------------
Marked as reviewed by aghaisas (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1220#pullrequestreview-1657108439
More information about the openjfx-dev
mailing list