Integrated: JDK-8313628: Column drag header, overlay and line are not correctly aligned

Marius Hanl mhanl at openjdk.org
Mon Oct 9 21:02:10 UTC 2023


On Wed, 2 Aug 2023 16:36:47 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

> When a table has padding or the `layoutChildren` method inside the table skin is overridden (and x/y are modified), the drag drag header, column overlay and column line are not correctly aligned.
> 
> The reason is that the positions were calculated incorrectly.
> - **Column overlay and column line**
> Always calculate in the x and y from the table. The x and y variables contain the snapped insets (padding) and possible modifications from subclasses.
> - **Drag header**
> Calculate the drag x offset local bounds from the parent header (which is either the parent column header or the root header)
> Before, the local bounds were calculated from the table, which will wrongly calculate in the padding.
> We do not want to know the local bounds based of the whole table but of our header we are in.

This pull request has now been integrated.

Changeset: 2ec33435
Author:    Marius Hanl <mhanl at openjdk.org>
URL:       https://git.openjdk.org/jfx/commit/2ec33435da44e6dc4791ecb1a37c064125c2ca13
Stats:     371 lines in 5 files changed: 336 ins; 7 del; 28 mod

8313628: Column drag header, overlay and line are not correctly aligned

Reviewed-by: angorya, kpk

-------------

PR: https://git.openjdk.org/jfx/pull/1193


More information about the openjfx-dev mailing list