RFR: 8313321 : Set minimum python version in WebKit cmake scripts

Kevin Rushforth kcr at openjdk.org
Tue Oct 10 12:13:35 UTC 2023


On Mon, 14 Aug 2023 15:52:03 GMT, Hima Bindu Meda <hmeda at openjdk.org> wrote:

>> I tested this on my MacBook Pro running macOS 13.3.1 and discovered that it has python 3.7.x:
>> 
>> 
>>   Could NOT find Python3: Found unsuitable version "3.7.3", but required is
>>   at least "3.8.0" (found /usr/bin/python3, found components: Interpreter)
>> 
>> 
>> Since the motivation for checking the minimum was both to avoid python2, and because there is a problem with python 3.7 on Windows, I wonder if it would be better to only have Windows require 3.8 and have Mac join Linux in allowing 3.6. Of course, I could upgrade my python, but I wonder if other developers might run into it.
>
>> I tested this on my MacBook Pro running macOS 13.3.1 and discovered that it has python 3.7.x:
>> 
>> ```
>>   Could NOT find Python3: Found unsuitable version "3.7.3", but required is
>>   at least "3.8.0" (found /usr/bin/python3, found components: Interpreter)
>> ```
>> 
>> Since the motivation for checking the minimum was both to avoid python2, and because there is a problem with python 3.7 on Windows, I wonder if it would be better to only have Windows require 3.8 and have Mac join Linux in allowing 3.6. Of course, I could upgrade my python, but I wonder if other developers might run into it.
> 
> Based on the observation, changed the minimum version to 3.6 for mac and linux , and 3.8 for Windows

@HimaBinduMeda Can you merge in the latest master? I'll re-review once you do.

Regarding John's comment:

> Just a note that I was unable to build WebKit on Windows using the latest Python version 3.9

Let's file a follow-up bug for this if one is not already filed.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1205#issuecomment-1755254910


More information about the openjfx-dev mailing list