RFR: 8317370: JavaFX runtime version is wrong at runtime [v2]

Tue Oct 10 16:36:17 UTC 2023

On Tue, 10 Oct 2023 16:24:42 GMT, John Neffenger <jgneff at openjdk.org> wrote:

>> Please review these changes to the build timestamp and to the JavaFX runtime version available in the system properties.
>
> John Neffenger has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update the documentation in UPDATING-VERSION.md

Looks good.

> To all reviewers: I added tests of the method [VersionInfo.setupSystemProperties](https://github.com/openjdk/jfx/blob/master/modules/javafx.base/src/main/version-info/VersionInfo.java#L152) to the test cases in my [personal repository](https://github.com/jgneff/version-info-test/commit/573f559). It's kind of overkill, and not necessary to prevent this bug, but let me know if I should add them anyway.

Yeah, I probably wouldn't add them.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1253#pullrequestreview-1668250025
PR Comment: https://git.openjdk.org/jfx/pull/1253#issuecomment-1755804456