RFR: 8317370: JavaFX runtime version is wrong at runtime [v2]
Florian Kirmaier
fkirmaier at openjdk.org
Thu Oct 12 09:23:19 UTC 2023
On Tue, 10 Oct 2023 16:24:42 GMT, John Neffenger <jgneff at openjdk.org> wrote:
>> Please review these changes to the build timestamp and to the JavaFX runtime version available in the system properties.
>
> John Neffenger has updated the pull request incrementally with one additional commit since the last revision:
>
> Update the documentation in UPDATING-VERSION.md
Based on the changes, it looks great - fewer variables, less code, more tests.
It's now also easier to follow, what the "no_hudson" flag does.
The ":" is now also removed from the version String - so my previous change would no longer be required.
But I guess it doesn't hurt either.
I tested making a build, and it works well!
So from my point of view, it looks quite great!
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1253#issuecomment-1759244834
More information about the openjfx-dev
mailing list