RFR: 8306083: Text.hitTest is incorrect when more than one Text node in TextFlow [v8]

Karthik P K kpk at openjdk.org
Thu Oct 12 09:42:23 UTC 2023


On Tue, 3 Oct 2023 10:03:00 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> The text run selected in `PrismTextLayout::getHitInfo()` method for character index calculation was not correct when hitTest was invoked for Text node in a TextFlow with more than one Text child. Hence wrong character index value was calculated.
>> 
>> Since only x, y coordinates were available in the above mentioned method, sending the text as a parameter to this method is necessary so as to know if the text run selected for character index calculation is correct. Along with this change modified the `PrismTextLayout::getHitInfo()` method to calculate the correct character index.
>> 
>> Added tests to validate the changes.
>
> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments

Fixed the issue when more than one text nodes with same text is present in text node. Added new test cases and improved current tests.
@andy-goryachev-oracle and @prrace please re-review.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1157#issuecomment-1759276591


More information about the openjfx-dev mailing list