RFR: 8306083: Text.hitTest is incorrect when more than one Text node in TextFlow [v10]
Karthik P K
kpk at openjdk.org
Fri Oct 13 07:01:51 UTC 2023
> The text run selected in `PrismTextLayout::getHitInfo()` method for character index calculation was not correct when hitTest was invoked for Text node in a TextFlow with more than one Text child. Hence wrong character index value was calculated.
>
> Since only x, y coordinates were available in the above mentioned method, sending the text as a parameter to this method is necessary so as to know if the text run selected for character index calculation is correct. Along with this change modified the `PrismTextLayout::getHitInfo()` method to calculate the correct character index.
>
> Added tests to validate the changes.
Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
Review comments
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/1157/files
- new: https://git.openjdk.org/jfx/pull/1157/files/34639797..c0f1f9f1
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=1157&range=09
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=1157&range=08-09
Stats: 14 lines in 3 files changed: 6 ins; 1 del; 7 mod
Patch: https://git.openjdk.org/jfx/pull/1157.diff
Fetch: git fetch https://git.openjdk.org/jfx.git pull/1157/head:pull/1157
PR: https://git.openjdk.org/jfx/pull/1157
More information about the openjfx-dev
mailing list