RFR: Draft: 8316423: [linux] Secondary Stage does not respect Scene's dimensions when shown [v6]

Thiago Milczarek Sayao tsayao at openjdk.org
Sun Oct 15 13:13:23 UTC 2023


On Sun, 15 Oct 2023 00:32:47 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

>> It looks like a condition between calls from `set_visible` to `request_focus`. When `request_focus` is called, the window is not yet mapped (map is requested on `set_visible`). 
>> 
>> 200x200 is the default gtk window size if none is specified. Since the window is presented at the requested size and then changes to 200x200 I would guess the size request on `gtk_window_present` (which is called on `request_focus`) is being queued and released later. But I'm not really sure.
>> 
>> With this change immediate `request_focus` after the window is created will be ignored. But the default is to request focus on map, so it will work. `request_focus` will only be useful when called after the window is mapped (presented on the screen).
>> 
>> This also fixes [JDK-8316425](https://bugs.openjdk.org/browse/JDK-8316425)
>
> Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert "Test"
>   
>   This reverts commit ac7b4da75b9690c42aecd484bb3990866a004074.

Filed a bug on Mutter [here](https://gitlab.gnome.org/GNOME/mutter/-/issues/3092).

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1249#issuecomment-1763385062


More information about the openjfx-dev mailing list