RFR: 8318204: Use new EventTarget methods in ListenerHelper

Nir Lisker nlisker at openjdk.org
Tue Oct 17 11:06:24 UTC 2023


On Tue, 17 Oct 2023 04:46:12 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

> As of OpenJFX 21, `EventTarget` has methods to add and remove event listeners.
> The `instanceof` checks in `com.sun.javafx.scene.control.ListenerHelper` should be removed and replaced by a simple call to the respective interface method.

Looks good.

By the way, isn't `IDisconnectable` just a `Subscription` with less gadgets?

-------------

Marked as reviewed by nlisker (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1262#pullrequestreview-1682025487


More information about the openjfx-dev mailing list