RFR: 8185831: Psuedo selectors do not appear to work in Node.lookupAll() [v3]

Sai Pradeep Dandem duke at openjdk.org
Thu Oct 19 00:13:19 UTC 2023


> **Issue:**
> Using pseudo classes in programmatic query using Node.lookupAll() or Node.lookup() gives unexpected results.
> 
> **Cause:**
> There is no check for checking the psuedo states matching in the applies() method of SimpleSelector.java. So checking for "applies()" alone is not sufficient in lookup() method.
> 
> **Fix:**
> Included an extra check for the psuedo states to match.

Sai Pradeep Dandem has updated the pull request incrementally with one additional commit since the last revision:

  8185831: Fixed code review comments

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1245/files
  - new: https://git.openjdk.org/jfx/pull/1245/files/75323661..6a18fb54

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1245&range=02
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1245&range=01-02

  Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jfx/pull/1245.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1245/head:pull/1245

PR: https://git.openjdk.org/jfx/pull/1245


More information about the openjfx-dev mailing list