RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v8]

John Hendrikx jhendrikx at openjdk.org
Fri Oct 20 08:39:51 UTC 2023


On Fri, 20 Oct 2023 03:28:08 GMT, Sai Pradeep Dandem <duke at openjdk.org> wrote:

>> **Issue:**
>> Using pseudo classes in programmatic query using Node.lookupAll() or Node.lookup() gives unexpected results.
>> 
>> **Cause:**
>> There is no check for checking the psuedo states matching in the applies() method of SimpleSelector.java. So checking for "applies()" alone is not sufficient in lookup() method.
>> 
>> **Fix:**
>> Included an extra check for the psuedo states to match.
>
> Sai Pradeep Dandem has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8185831: Renamed test methods

Looks good, although I do think this needs to be documented on the public methods (it should not be a separate PR).

-------------

PR Review: https://git.openjdk.org/jfx/pull/1245#pullrequestreview-1689534672


More information about the openjfx-dev mailing list