RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v7]

Andy Goryachev angorya at openjdk.org
Fri Oct 20 15:36:43 UTC 2023


On Fri, 20 Oct 2023 03:26:51 GMT, Sai Pradeep Dandem <duke at openjdk.org> wrote:

>> modules/javafx.graphics/src/test/java/test/javafx/scene/Node_lookup_Test.java line 202:
>> 
>>> 200:      */
>>> 201:     @Test
>>> 202:     public void lookupPseudoTest3() {
>> 
>> Consider naming the test methods according to what they test.
>
> Renamed the methods by referring to method names used in other classes. I noticed that descriptive long method names is accepted, so named similarly. The only thing I want to check is: I renamed existing methods also. Is it accepted? or I am not allowed to rename others method names?

I see no problem renaming: there are no dependencies.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1245#discussion_r1367154867


More information about the openjfx-dev mailing list