RFR: 8205067: Resizing window with TextField hides text value [v2]

Andy Goryachev angorya at openjdk.org
Wed Oct 25 15:15:39 UTC 2023


On Wed, 25 Oct 2023 10:12:01 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> Because of a missing conditional check in the `updateTextPos()`,  the `textTranslateX` value was not getting updated when TextField size was changed as a result of resizing window.
>> 
>> Updated the CENTER and LEFT cases in the `updateTextPos()` method to fix the issue.
>> 
>> The fix can be validated using MonkeyTester.
>> Steps to select TextField option in Monkey Tester.
>> 
>> - Open the MonkeyTester app and select TextField from the left option pane.
>> - Select Long from Text selection option and TOP_LEFT from Alignment dropdown.
>> - After above step, follow the steps given in the bug to validate the fix in monkey tester.
>
> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments

Marked as reviewed by angorya (Reviewer).

Works beautifully, even with the split caret:

![Screenshot 2023-10-25 at 08 11 31](https://github.com/openjdk/jfx/assets/107069028/5b251cbb-ce3a-4306-a3c2-2a21316fbc0e)

good job!

-------------

PR Review: https://git.openjdk.org/jfx/pull/1263#pullrequestreview-1697645285
PR Comment: https://git.openjdk.org/jfx/pull/1263#issuecomment-1779506958


More information about the openjfx-dev mailing list